lkml.org 
[lkml]   [2008]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: broken ownership of /proc/sys/ files on 2.6.27
On Sun, 16 Nov 2008, Al Viro wrote:

> On Sun, Nov 16, 2008 at 09:59:22PM +0100, Peter Palfrader wrote:
> > Hi,
> >
> > on several (probably all) of my systems running a 2.6.27 kernel on at
> > least i386, amd64, ia64, sparc proc/sys does have files not owned by
> > root:
>
> D'oh...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
> index 94fcfff..06ed10b 100644
> --- a/fs/proc/proc_sysctl.c
> +++ b/fs/proc/proc_sysctl.c
> @@ -31,6 +31,7 @@ static struct inode *proc_sys_make_inode(struct super_block *sb,
> inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
> inode->i_flags |= S_PRIVATE; /* tell selinux to ignore this inode */
> inode->i_mode = table->mode;
> + inode->i_uid = inode->i_gid = 0;
> if (!table->child) {
> inode->i_mode |= S_IFREG;
> inode->i_op = &proc_sys_inode_operations;

Works on the one host that I tested.

Thanks.
--
| .''`. ** Debian GNU/Linux **
Peter Palfrader | : :' : The universal
http://www.palfrader.org/ | `. `' Operating System
| `- http://www.debian.org/


\
 
 \ /
  Last update: 2008-11-16 23:41    [W:0.050 / U:23.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site