Messages in this thread |  | | Date | Sun, 16 Nov 2008 23:30:14 +0100 | From | Samuel Ortiz <> | Subject | Re: [PATCH 2.6.28] mfd: Correct WM8350 I2C return code usage |
| |
On Wed, Nov 12, 2008 at 11:43:31PM +0000, Mark Brown wrote: > > With this patch you're breaking that expectation because the read|write_dev() > > I'd prefer to fix the callers code, so that we keep the expected semantics > > Just to clarify, when you say "expectation" and "fix" are you talking > about your preference that the hardware access functions return the > number of bytes read or written or is there something else going on > here? No, definitely just my preference. I personnaly expect this kind of IO routines to return the number of bytes read/written.
> To be honest I'm really not sure it's worth changing this - I'm having a > hard time thinking of a user that would be able to do anything useful > with a short access. I agree with that, yes.
> It also seems like it'd be a rather invasive > change for an -rc. Fair enough, I applied your patch, and sent Linus a pull request.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
|  |