lkml.org 
[lkml]   [2008]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 3/7] memcontrol: use simple_malloc()/simple_free()
On Sun, Nov 16, 2008 at 07:51:28AM +0300, Alexey Dobriyan wrote:
> On Sun, Nov 16, 2008 at 12:33:46PM +0800, Lai Jiangshan wrote:
> > use simple_malloc()/simple_free() instead of current codes.
>
> struct mem_cgroup can't reach the size when kmalloc starts failing.

Or it probably can with big NR_CPUS.

struct mem_cgroup_stat {
struct mem_cgroup_stat_cpu cpustat[NR_CPUS];
};

> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -1062,11 +1062,7 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
> > {
> > struct mem_cgroup *mem;
> >
> > - if (sizeof(*mem) < PAGE_SIZE)
> > - mem = kmalloc(sizeof(*mem), GFP_KERNEL);
> > - else
> > - mem = vmalloc(sizeof(*mem));
> > -
> > + mem = simple_malloc(sizeof(*mem));
> > if (mem)
> > memset(mem, 0, sizeof(*mem));
> > return mem;
> > @@ -1074,10 +1070,7 @@ static struct mem_cgroup *mem_cgroup_alloc(void)
> >
> > static void mem_cgroup_free(struct mem_cgroup *mem)
> > {
> > - if (sizeof(*mem) < PAGE_SIZE)
> > - kfree(mem);
> > - else
> > - vfree(mem);
> > + simple_free(mem);
> > }


\
 
 \ /
  Last update: 2008-11-16 05:53    [W:0.059 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site