lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: Add WM8350 LED driver
On Thu, 13 Nov 2008 12:39:57 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> The voltage and current regulators on the WM8350 AudioPlus PMIC can be
> used in concert to provide a power efficient LED driver. This driver
> implements support for this within the standard LED class.
>
> Platform initialisation code should configure the LED hardware in the
> init callback provided by the WM8350 core driver. The callback should
> use wm8350_isink_set_flash(), wm8350_dcdc25_set_mode() and
> wm8350_dcdc_set_slot() to configure the operating parameters of the
> regulators for their hardware and then then use wm8350_register_led() to
> instantiate the LED driver.
>
> This driver was originally written by Liam Girdwood, though it has been
> extensively modified since then.
>
> ...
>
> +static void wm8350_led_disable(struct wm8350_led *led)
> +{
> + int ret;
> +
> + if (!led->enabled)
> + return;
> +
> + ret = regulator_disable(led->dcdc);
> + if (ret != 0) {
> + dev_err(led->cdev.dev, "Failed to disable DCDC: %d\n", ret);
> + return;
> + }
> +
> + ret = regulator_disable(led->isink);
> + if (ret != 0) {
> + dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
> + regulator_enable(led->isink);

Should be regulator_enable(led->dcdc), yes?

> + return;
> + }
> +
> + led->enabled = 0;
> +}
> +
>
> ...
>
> +static int wm8350_led_remove(struct platform_device *pdev)
> +{
> + struct wm8350_led *led =
> + (struct wm8350_led *)platform_get_drvdata(pdev);

unneeded and undesirable cast of void*.

> + led_classdev_unregister(&led->cdev);
> + schedule_work(&led->work);
> + flush_scheduled_work();

The schedule_work() is unexpected and I can't immediately see why it's
here. If it is indeed correct, I'd suggest the addition of a comment.

> + wm8350_led_disable(led);
> + regulator_put(led->dcdc);
> + regulator_put(led->isink);
> + kfree(led);
> + return 0;
> +}
> +



\
 
 \ /
  Last update: 2008-11-15 00:21    [W:0.066 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site