Messages in this thread | | | Date | Thu, 13 Nov 2008 20:32:47 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from one page into another |
| |
On Thu, 13 Nov 2008 12:38:07 +0200 Izik Eidus <ieidus@redhat.com> wrote: > > If KSM pages are on radix-tree, it will be accounted automatically. > > Now, we have "Unevictable" LRU and mlocked() pages are smartly isolated into its > > own LRU. So, just doing > > > > - inode's radix-tree > > - make all pages mlocked. > > - provide special page fault handler for your purpose > > > > Well in this version that i am going to merge the pages arent going to > be swappable, > Latter after Ksm will get merged we will make the KsmPages swappable... good to hear
> so i think working with cgroups would be effective / useful only when > KsmPages will start be swappable... > Do you agree? > (What i am saying is that right now lets dont count the KsmPages inside > the cgroup, lets do it when KsmPages > will be swappable) > ok.
> If you feel this pages should be counted in the cgroup i have no problem > to do it via hooks like page migration is doing. > > thanks. > > > is simple one. But ok, whatever implementation you'll do, I have to check it > > and consider whether it should be tracked or not. Then, add codes to memcg to > > track it or ignore it or comments on your patches ;) > > > > It's helpful to add me to CC: when you post this set again. > > > > Sure will. >
If necessary, I'll have to add "ignore in this case" hook in memcg. (ex. checking PageKSM flag in memcg.)
If you are sufferred from memcg in your test, cgroup_disable=memory boot option will allow you to disable memcg.
Thanks, -Kame
| |