lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] 8250: Oxford Semiconductor Devices
> > +		number_uarts = ioread8(p + 4);
> > + board->num_ports = number_uarts;
>
> Why not just return number of ports here ?

That would leak mappings
>
> > + printk(KERN_DEBUG
> > + "%d ports detected on Oxford PCI Express device\n",
> > + number_uarts);
>
> Is this printk really necessary ?

For the moment yes.

> WTF is this ? Why existing pci_serial_quirks[] infrastructure cannot be used here ?

Russell already fixed that and the change went upstream.



\
 
 \ /
  Last update: 2008-11-13 11:01    [W:2.835 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site