Messages in this thread | | | Date | Thu, 13 Nov 2008 09:59:25 +0000 | From | Alan Cox <> | Subject | Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices |
| |
> > + number_uarts = ioread8(p + 4); > > + board->num_ports = number_uarts; > > Why not just return number of ports here ?
That would leak mappings > > > + printk(KERN_DEBUG > > + "%d ports detected on Oxford PCI Express device\n", > > + number_uarts); > > Is this printk really necessary ?
For the moment yes.
> WTF is this ? Why existing pci_serial_quirks[] infrastructure cannot be used here ?
Russell already fixed that and the change went upstream.
| |