lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: unify mtd partition/device registration
On Thu, Nov 13, 2008 at 10:51, Atsushi Nemoto wrote:
> On Thu, 13 Nov 2008 09:51:01 -0500, "Mike Frysinger" wrote:
>> > Automatic fallback to mtd_device in parse_mtd() is convenient but
>> > somewhat unflexible...
>>
>> we could just have it do it all the time. i dont see a problem with
>> exposing the entire block device the whole time ? i know for the
>> driver or two of mine, i'm fine with it.
>>
>> ...
>> ret = parse_mtd_partitions(mtd, probe_types, &parts, 0);
>> if (ret > 0) {
>> ret = add_mtd_partitions(mtd, parts, ret);
>> kfree(parts);
>> } else if (nr_parts)
>> ret = add_mtd_partitions(mtd, parts, nr_parts);
>> if (ret)
>> return ret;
>> #endif
>>
>> return add_mtd_device(mtd);
>
> I'm OK with this. But not sure all current mtd partition users.
>
> Are you going to convert all parse_mtd_partitions() call? Maybe some
> people do not want to change /dev/mtd numbers...

if it's a real concern, we can make it optional. i'll post patches to
convert physmap and my drivers as those are the only ones i can
actually test.
-mike


\
 
 \ /
  Last update: 2008-11-13 16:59    [W:0.033 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site