lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: unify mtd partition/device registration
On Thu, Nov 13, 2008 at 08:43, Atsushi Nemoto wrote:
> On Wed, 12 Nov 2008 18:38:53 -0500, Mike Frysinger wrote:
>> +int parse_mtd(struct mtd_info *mtd, const char **probe_types,
>> + struct mtd_partition *parts, int nr_parts)
>> +{
>> +#ifdef CONFIG_MTD_PARTITIONS
>> + const char *default_part_probe_types[] = {
>> + "cmdlinepart",
>> + "RedBoot",
>> + NULL
>> + };
>
> But I'm not sure this default_part_probe_types is appropriate.
>
> How about enclose each parser with #ifdefs?
>
> const char *default_part_probe_types[] = {
> #ifdef CONFIG_MTD_CMDLINE_PARTS
> "cmdlinepart",
> #endif
> #ifdef CONFIG_MTD_REDBOOT_PARTS
> "RedBoot",
> #endif
> NULL
> };
>
> This get rid of "RedBoot partition parsing not available" noise in
> boot message when you use default_part_probe_types without
> MTD_REDBOOT_PARTS.

yeah, that parsing thing is annoying, but i didnt think enough so to
add ifdef's. i'm fine with it either way.
-mike


\
 
 \ /
  Last update: 2008-11-13 15:55    [from the cache]
©2003-2011 Jasper Spaans