Messages in this thread | | | Date | Thu, 13 Nov 2008 08:16:34 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH v2 1/1] ftrace: do not update max buffer with no users |
| |
On Thu, 13 Nov 2008, Steven Rostedt wrote: > > > Reported-by: Pekka Paalanen <pq@iki.fi> > > > Signed-off-by: Steven Rostedt <srostedt@redhat.com> > > > --- > > > kernel/trace/trace.c | 171 ++++++++++++++++++++++++++------------------------ > > > 1 files changed, 88 insertions(+), 83 deletions(-) > > > > This is _way_ too much churn for .28, we need a much simpler solution. > > The line count is very misleading. The 83 insertions and deletions where > moved code or indentation: >
> > As you can easily see, the change only added the test for max_tr.buffer > exists, and indented the rest. > > The other parts you can easily see that they are not changed. > But, we could separate out the moved code and ifdef protection for 29, > even though I feel nervous that some config might use them, and break at > runtime. This change will break the compile if it happens. Without the > change, we find out at runtime :-(
Also, if you are worried about line count, I could just leave the code in place, and add more ifdefs around them, and leave the consolidation of the code for 29.
-- Steve
| |