Messages in this thread Patch in this message | | | Date | Wed, 12 Nov 2008 17:24:29 +0000 | From | Nick Warne <> | Subject | Re: [PATCH] Make Dell keyboard repeat quirk apply to a wider range of hardware |
| |
On Wed, 12 Nov 2008 16:56:50 +0000 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> Does this work? > > diff --git a/drivers/input/keyboard/atkbd.c > b/drivers/input/keyboard/atkbd.c index 22016ca..15479ef 100644 > --- a/drivers/input/keyboard/atkbd.c > +++ b/drivers/input/keyboard/atkbd.c > @@ -1460,6 +1460,15 @@ static struct dmi_system_id > atkbd_dmi_quirk_table[] __initdata = { .driver_data = > atkbd_dell_laptop_keymap_fixup, }, > { > + .ident = "Dell Laptop", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer > Corporation"), > + DMI_MATCH(DMI_CHASSIS_TYPE, "8"), /* > Portable */ > + }, > + .callback = atkbd_setup_fixup, > + .driver_data = atkbd_dell_laptop_keymap_fixup, > + }, > + { > .ident = "HP 2133", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), >
Matthew,
The original worked for me fine, and a lot of other people as our Dell laptops produce 'Dell Inc.' as vendor. But other peoples return 'Dell Computer Corporation' and thus it didn't work for them.
But how you determine if these certain laptops produce a keypress release I don't know with having all of them at hand...
So it needs BOTH 'Dell Inc.' and 'Dell Computer Corporation' to cover these laptops (I guess), as per the info I got from people running dmidecode:
http://ubuntuforums.org/showthread.php?t=978973
Nick -- Free Software Foundation Associate Member 5508
| |