lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: try to catch missing VMLINUX_SYMBOL() in vmlinux.lds.h
On Sat, Nov 08, 2008 at 05:56:05PM -0500, Mike Frysinger wrote:
> Seems like every other release we have someone who updates vmlinux.lds.h and
> adds C-visible symbols without VMLINUX_SYMBOL() around them. So start
> checking the file and only allow assignments that use one of the following
> symbols on a side:
> .
> ALIGN(...)
> VMLINUX_SYMBOL(...)
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> scripts/checkpatch.pl | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f88bb3e..8e96b42 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2189,6 +2189,19 @@ sub process {
> }
> }
>
> +# make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
> +# all assignments may have only one of the following with an assignment:
> +# .
> +# ALIGN(...)
> +# VMLINUX_SYMBOL(...)
> + if ($realfile =~ /vmlinux.lds.h$/) {
> + if ($line =~ /=/ &&
> + !($line =~ /([.]|(ALIGN|VMLINUX_SYMBOL)[(][^=]*[)])\s*=\s*([.]|(ALIGN|VMLINUX_SYMBOL)[(][^=]*[)])/))
> + {
> + WARN("vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
> + }
> + }
> +
> # check for redundant bracing round if etc
> if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
> my ($level, $endln, @chunks) =
> --

Ok, that seems like a sane check. I think what we are really wanting
to check for is assigments with plain identifiers on either side? I've
pushed a softened version of this check to my tree for testing.

http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw


\
 
 \ /
  Last update: 2008-11-12 15:05    [W:0.049 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site