lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] tracing: branch tracer, tweak output

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Wed, 12 Nov 2008, Ingo Molnar wrote:
>
> >
> > a small detail:
> >
> > > For example:
> > >
> > > bash-3471 [003] 357.014755: [INCORRECT] sched_info_dequeued:sched_stats.h:177
> > > bash-3471 [003] 357.014756: [correct] update_curr:sched_fair.c:489
> > > bash-3471 [003] 357.014758: [correct] calc_delta_fair:sched_fair.c:411
> > > bash-3471 [003] 357.014759: [correct] account_group_exec_runtime:sched_stats.h:356
> > > bash-3471 [003] 357.014761: [correct] update_curr:sched_fair.c:489
> > > bash-3471 [003] 357.014763: [INCORRECT] calc_delta_fair:sched_fair.c:411
> > > bash-3471 [003] 357.014765: [correct] calc_delta_mine:sched.c:1279
> >
> > it's always good to have such fields aligned vertically. Something
> > like this would be shorter and visually much easier to parse:
> >
> > bash-3471 [003] 357.014755: [ MISS ] sched_info_dequeued:sched_stats.h:177
> > bash-3471 [003] 357.014756: [ .... ] update_curr:sched_fair.c:489
> > bash-3471 [003] 357.014758: [ .... ] calc_delta_fair:sched_fair.c:411
> >
> > any objections against the patch below which implements this?
>
> How about "[ OK ]" instead of "[ .... ]". That would be easier to
> understand.

ok, agreed - just the use of capitals is not good, as it unnecessarily
draws visual attention. How about:

> bash-3471 [003] 357.014755: [ MISS ] sched_info_dequeued:sched_stats.h:177
> bash-3471 [003] 357.014756: [ ok ] update_curr:sched_fair.c:489
> bash-3471 [003] 357.014758: [ ok ] calc_delta_fair:sched_fair.c:411

via the patch below?

Ingo

-------------->
From 68d119f0a66f7e3663304343b072e56a2693446b Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 12 Nov 2008 14:09:30 +0100
Subject: [PATCH] tracing: finetune branch-tracer output

Steve suggested the to change the output from this:

> bash-3471 [003] 357.014755: [ MISS ] sched_info_dequeued:sched_stats.h:177
> bash-3471 [003] 357.014756: [ .... ] update_curr:sched_fair.c:489
> bash-3471 [003] 357.014758: [ .... ] calc_delta_fair:sched_fair.c:411

to this:

> bash-3471 [003] 357.014755: [ MISS ] sched_info_dequeued:sched_stats.h:177
> bash-3471 [003] 357.014756: [ ok ] update_curr:sched_fair.c:489
> bash-3471 [003] 357.014758: [ ok ] calc_delta_fair:sched_fair.c:411

as it makes it clearer to the user what it means exactly.

Acked-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/trace/trace.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 728a46e..d842db1 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1657,7 +1657,7 @@ print_lat_fmt(struct trace_iterator *iter, unsigned int trace_idx, int cpu)
trace_assign_type(field, entry);

trace_seq_printf(s, "[%s] %s:%s:%d\n",
- field->correct ? " .... " : " MISS ",
+ field->correct ? " ok " : " MISS ",
field->func,
field->file,
field->line);
@@ -1808,7 +1808,7 @@ static enum print_line_t print_trace_fmt(struct trace_iterator *iter)
trace_assign_type(field, entry);

trace_seq_printf(s, "[%s] %s:%s:%d\n",
- field->correct ? " .... " : " MISS ",
+ field->correct ? " ok " : " MISS ",
field->func,
field->file,
field->line);

\
 
 \ /
  Last update: 2008-11-12 14:17    [W:0.067 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site