lkml.org 
[lkml]   [2008]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] ring-buffer: buffer record on/off switch

[ Added Andy on Cc ]

On Tue, 11 Nov 2008, Andrew Morton wrote:

> On Tue, 11 Nov 2008 15:06:02 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > +static struct file_operations rb_simple_fops = {
>
> should be const...
>
> Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> 10% of our file_operationses aren't const.

I wonder if this should be added to checkpatch?

-- Steve



\
 
 \ /
  Last update: 2008-11-11 22:09    [W:0.553 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site