Messages in this thread | | | Date | Tue, 11 Nov 2008 14:47:06 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine_halt |
| |
* Ivan Vecera <ivecera@redhat.com> wrote:
> Ingo Molnar wrote: > > looks good. One small detail: > > > >> +#ifdef CONFIG_X86_LOCAL_APIC > >> + disable_local_APIC(); > >> +#endif > > > > could you please avoid this #ifdef by putting an inline void function > > for disable_local_APIC() into arch/x86/include/asm/apic.h for the > > !CONFIG_X86_LOCAL_APIC case? > > > > Ingo > OK, here is the result. > > Ivan > > --- > arch/x86/include/asm/apic.h | 1 + > arch/x86/include/asm/system.h | 2 ++ > arch/x86/kernel/process.c | 14 ++++++++++++++ > arch/x86/kernel/reboot.c | 5 +++++ > arch/x86/kernel/smp.c | 13 ------------- > 5 files changed, 22 insertions(+), 13 deletions(-)
applied to tip/x86/reboot, thanks Ivan!
Ingo
| |