Messages in this thread | | | Date | Mon, 10 Nov 2008 19:43:53 -0800 | From | Andrew Morton <> | Subject | Re: rc4-mmotm1110 - Another build error |
| |
On Mon, 10 Nov 2008 22:20:33 -0500 Valdis.Kletnieks@vt.edu wrote:
> gcc --version says: > gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7) > > ka-blam number 2: > > CC kernel/audit.o > In file included from include/net/dst.h:15, > from include/net/sock.h:57, > from kernel/audit.c:54: > include/net/neighbour.h:114: error: braced-group within expression allowed only inside a function > make[1]: *** [kernel/audit.o] Error 1 > > I'm placing bets on patches/align-avoid-evaluating-its-argument-twice.patch > > Yep, revert that patch, and audit.o compiles again. >
I hadn't got around to testing that one yet.
So ug. ALIGN() is used in array sizing and hence has to be a compile-time thing. But ALIGN(foo, bar()) will call bar() twice.
Now how do we fix that?
| |