Messages in this thread | | | Date | Mon, 10 Nov 2008 23:47:44 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] serial/8250: fix uninitialized warnings |
| |
> hlist_for_each() can execute that loop zero times, in which case > serial_unlink_irq_chain will dereference an uninitialised variable. > > Presumably the list shouldn't be empty at this stage, but this > is not particularly robust behaviour if that should happen..
And the only cases that can trip are the more important BUG_ON() checks. You could remove the BUG_ON() calls and make it less robust but that seems slightly well silly to me ?
Alan
| |