lkml.org 
[lkml]   [2008]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 34/42] jbd2: Fix buffer head leak when writing the commit block
    Date
    Also make sure the buffer heads are marked clean before submitting bh
    for writing. The previous code was marking the buffer head dirty,
    which would have forced an unneeded write (and seek) to the journal
    for no good reason.

    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    ---
    fs/jbd2/commit.c | 5 ++---
    1 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
    index e91f051..0d3814a 100644
    --- a/fs/jbd2/commit.c
    +++ b/fs/jbd2/commit.c
    @@ -127,8 +127,7 @@ static int journal_submit_commit_record(journal_t *journal,

    JBUFFER_TRACE(descriptor, "submit commit block");
    lock_buffer(bh);
    - get_bh(bh);
    - set_buffer_dirty(bh);
    + clear_buffer_dirty(bh);
    set_buffer_uptodate(bh);
    bh->b_end_io = journal_end_buffer_io_sync;

    @@ -158,7 +157,7 @@ static int journal_submit_commit_record(journal_t *journal,
    /* And try again, without the barrier */
    lock_buffer(bh);
    set_buffer_uptodate(bh);
    - set_buffer_dirty(bh);
    + clear_buffer_dirty(bh);
    ret = submit_bh(WRITE, bh);
    }
    *cbh = bh;
    --
    1.5.6.1.205.ge2c7.dirty


    \
     
     \ /
      Last update: 2008-10-09 06:23    [W:0.036 / U:31.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site