lkml.org 
[lkml]   [2008]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] markers: fix unchecked format

* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> >
> > No.
> >
> > 1)
> > In current code, when the second, third... probe is registered
> > with the same marker name, its format is not checked.
> >
> > marker_probe_register("marker_name", "field1 %s", XXX);
> > marker_probe_register("marker_name", "field1 %d", XXX);
> >
> > the second call, "field1 %d" is not check for ever.
> > and this probe may cause kernel core-dump.
> >
> > because these two probes share the same marker_entry, and
> > we do not check the format when they are being shared.
> >
> > if several probes share the same marker_entry we should
> > make sure all these probes's format are the same.
> >
>
> Yep, you are right. Thanks for the explanation.
>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

applied to tip/tracing/markers, thanks!

Ingo


\
 
 \ /
  Last update: 2008-10-09 16:07    [W:0.035 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site