[lkml]   [2008]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] documentation: explain memory barriers
Randy Dunlap wrote:
> On Wed, 1 Oct 2008 22:54:04 -0700 Andrew Morton wrote:
>> This sequence is repeated three or four times and should be pulled out
>> into a well-commented function. That comment should explain the logic
>> behind the use of these barriers, please.
> and on 2008-OCT-08 Ben Hutchings wrote:
>> All memory barriers need a comment to explain why and what they're doing.

Seriously? When a barrier is used, it's generally self-evident what
it's doing. The real problem is when a barrier is *not* used. It would
probably be more helpful to comment every non-barrier line of code to
explain why it's okay if memory operations are getting reordered.

-- Chris

 \ /
  Last update: 2008-10-09 03:21    [W:0.184 / U:9.564 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site