Messages in this thread | | | Date | Wed, 8 Oct 2008 17:07:51 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 1/3] x86: mtrr_cleanup update command line |
| |
On Tue, 30 Sep 2008 16:57:39 -0700 Randy Dunlap wrote:
> On Tue, 30 Sep 2008 16:29:38 -0700 Yinghai Lu wrote: > > > change enable_mtrr_cleanup to mtrr-cleanup, disable_mtrr_cleanup to nomtrr-cleanup. > > > > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> > > > > --- > > Documentation/kernel-parameters.txt | 4 ++-- > > arch/x86/Kconfig | 2 +- > > arch/x86/kernel/cpu/mtrr/main.c | 4 ++-- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > Index: linux-2.6/Documentation/kernel-parameters.txt > > =================================================================== > > --- linux-2.6.orig/Documentation/kernel-parameters.txt > > +++ linux-2.6/Documentation/kernel-parameters.txt > > @@ -614,8 +614,8 @@ and is between 256 and 4096 characters. > > See drivers/char/README.epca and > > Documentation/digiepca.txt. > > > > - disable_mtrr_cleanup [X86] > > - enable_mtrr_cleanup [X86] > > + nomtrr-cleanup [X86] > > + mtrr-cleanup [X86] > > The kernel tries to adjust MTRR layout from continuous > > to discrete, to make X server driver able to add WB > > entry later. This parameter enables/disables that. > > Looks like Documentation/kernel-parameters.txt needs a comment that says that > entries are supposed to be listed in alphabetical order, not grouped by <subject>. > Please don't add them like this.
BTW, this comment is alread in Documentation/kernel-parameters.txt, at the top of the file:
The following is a consolidated list of the kernel parameters as implemented (mostly) by the __setup() macro and sorted into English Dictionary order (defined as ignoring all punctuation and sorting digits before letters in a case insensitive manner), and with descriptions where known.
> E.g., the "apic" entries are not grouped together and these mtrr entries should > not be grouped together unless they all begin with "mtrr", which is an option here: > they could be renamed to "mtrr-cleanup" and "mtrr-nocleanup". > And "disable_mtrr_trim" could be renamed to "mtrr-notrim".
--- ~Randy
| |