Messages in this thread | | | Date | Wed, 8 Oct 2008 18:12:17 -0500 | From | "Eric Van Hensbergen" <> | Subject | Re: [V9fs-developer] [PATCH 04/10] 9p: move dirread to fs layer |
| |
On Wed, Oct 8, 2008 at 5:10 PM, Latchesar Ionkov <lucho@ionkov.net> wrote: > The idea of the client implementation is to be able to use it not only > from the vfs layer, but also without it. For example, creating a > device that connect to a remote 9P file server. >
That does make sense in principal -- although I'm not sure filldir structures are the easiest things to work with either. The main idea was to restrict the client.c code to wire operations, primarily torwards the idea of treating the "client" as a proxy server once the in-kernel-server code goes in (hopefully in 2.6.29). Of course the other factor is that this patch-set is gearing up towards an alternate extended-POSIX-support approach (what I've been referring to as .L) -- that extension will include a wire operation which more closely matches linux's concept of dirread (just grab the files, not the associated stat) -- but whether or not that is useful will largely depend on what sort of remote server you are accessing.
The Plan 9 dirread is one of those special cases where even though its not a wire operation, it needs some intimate understanding of the underlying protocol (at least how stats get marshalled) -- in some ways if it were a client operation, it might make more sense to pass it an array of p9_stat structs to populate with the results.
Do you have some code which used the old client interface I could look at or were you just thinking towards the future?
-eric
| |