Messages in this thread | | | Date | Wed, 8 Oct 2008 19:18:15 +0200 | From | Samuel Ortiz <> | Subject | Re: [patch 2.6.27-rc8-git] add drivers/mfd/twl4030-core.c |
| |
Hi Dave,
On Mon, Oct 06, 2008 at 10:47:49AM -0700, David Brownell wrote: > From: David Brownell <dbrownell@users.sourceforge.net> > > This patch adds the core of the TWL4030 driver, which supports > chips including the TPS65950. These chips are multi-function; see > > http://focus.ti.com/docs/prod/folders/print/tps65950.html > > Public specs are in the works. For now, the block diagram on > the second page of the datasheet is fairly informative. > > There are some known issues with this core code. Most notably, > the IRQ dispatching needs simplification (to use more of genirq), > generalization (integrating support for secondary IRQ dispatch > as well as primary, and removing the build dependency on OMAP), > and then probably updating to leverage threaded IRQ support > (expected to arrive in mainline "soon"). > > Once the core is in mainline, drivers for other parts of this > chip can follow its lead and start swimming upstream too. > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Thanks, applied to my mfd tree.
> +#if defined(CONFIG_TWL4030_BCI_BATTERY) || \ > + defined(CONFIG_TWL4030_BCI_BATTERY_MODUEL) minor typo, you probably meant: CONFIG_TWL4030_BCI_BATTERY_MODULE
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |