[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] serial: Add Cavium OCTEON UART definitions.
> + /* UPF_FIXED_PORT indicates an internal UART. */
> + if (up->port.flags & UPF_FIXED_PORT)
> + up->port.type = PORT_OCTEON;
> + else
> +#endif

Not nice. Please keep CPU specific ifdefs out of the 8250 core code. Can
you not set a port flag for UPF_BROKEN_OCTEON or similar to clean that up
and also make the other tests that need things doing (eg the always
calling IRQ code use port flags of a more generic nature ?)

 \ /
  Last update: 2008-10-07 12:31    [W:0.053 / U:7.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site