lkml.org 
[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] serial: 8250 driver replaceable i/o functions.
David Daney wrote:
> /* sane hardware needs no mapping */
> -static inline int map_8250_in_reg(struct uart_8250_port *up, int offset)
> +static inline int map_8250_in_reg(struct uart_port *p, int offset)
> {
> - if (up->port.iotype != UPIO_AU)
> + if (p->iotype != UPIO_AU)
> return offset;
> return au_io_in_map[offset];
> }

With your changes, these functions cannot be called with p->iotype !=
UPIO_AU anymore, correct? So there is no need for this test...

-hpa


\
 
 \ /
  Last update: 2008-10-08 02:15    [W:0.067 / U:30.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site