Messages in this thread | | | Date | Wed, 8 Oct 2008 08:44:50 +1100 (EST) | From | James Morris <> | Subject | RE: [RFC][PATCH 3/3] TXT: Intel(R) TXT and tboot kernel support |
| |
On Tue, 7 Oct 2008, Cihula, Joseph wrote:
> (large) Patch inline below (and still attached for those who prefer it).
It's now wordwrapped, and the other patches don't appear to have been resent at all.
Here's the appropriate section from SubmittingPatches. Note the section on configuring your mailer.
----
7) No MIME, no links, no compression, no attachments. Just plain text.
Linus and other kernel developers need to be able to read and comment on the changes you are submitting. It is important for a kernel developer to be able to "quote" your changes, using standard e-mail tools, so that they may comment on specific portions of your code.
For this reason, all patches should be submitting e-mail "inline". WARNING: Be wary of your editor's word-wrap corrupting your patch, if you choose to cut-n-paste your patch.
Do not attach the patch as a MIME attachment, compressed or not. Many popular e-mail applications will not always transmit a MIME attachment as plain text, making it impossible to comment on your code. A MIME attachment also takes Linus a bit more time to process, decreasing the likelihood of your MIME-attached change being accepted.
Exception: If your mailer is mangling patches then someone may ask you to re-send them using MIME.
See Documentation/email-clients.txt for hints about configuring your e-mail client so that it sends your patches untouched.
----
-- James Morris <jmorris@namei.org>
| |