Messages in this thread | | | Date | Tue, 7 Oct 2008 11:18:24 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [BUG] SLOB's krealloc() seems bust |
| |
On Tue, 7 Oct 2008, Peter Zijlstra wrote:
> On Tue, 2008-10-07 at 10:57 -0700, Linus Torvalds wrote: > > > Peter - can you check with that > > > > > if (slob_page(sp)) > > > - return ((slob_t *)block - 1)->units + SLOB_UNIT; > > > + return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT; > > > > thing using > > > > - return ((slob_t *)block - 1)->units + SLOB_UNIT; > > + return ((slob_t *)block - 1)->units * SLOB_UNIT; > > > > instead? > > went splat on the second run...
Well, that makes it simple. I'll take Matt's patch as being "tested", and somebody can hopefully explain where the extra unit comes from later.
Linus
| |