lkml.org 
[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUG] SLOB's krealloc() seems bust


    On Tue, 7 Oct 2008, Peter Zijlstra wrote:

    > On Tue, 2008-10-07 at 10:57 -0700, Linus Torvalds wrote:
    >
    > > Peter - can you check with that
    > >
    > > > if (slob_page(sp))
    > > > - return ((slob_t *)block - 1)->units + SLOB_UNIT;
    > > > + return (((slob_t *)block - 1)->units - 1) * SLOB_UNIT;
    > >
    > > thing using
    > >
    > > - return ((slob_t *)block - 1)->units + SLOB_UNIT;
    > > + return ((slob_t *)block - 1)->units * SLOB_UNIT;
    > >
    > > instead?
    >
    > went splat on the second run...

    Well, that makes it simple. I'll take Matt's patch as being "tested", and
    somebody can hopefully explain where the extra unit comes from later.

    Linus




    \
     
     \ /
      Last update: 2008-10-07 20:21    [W:0.053 / U:0.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site