lkml.org 
[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32 bit architecture
On Tue, 07 Oct 2008 11:55:47 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Mon, 2008-10-06 at 23:23 -0700, Andrew Morton wrote:
> > On Sun, 05 Oct 2008 21:28:10 -0400 "Theodore Ts'o" <tytso@mit.edu> wrote:
> >
> > > The following patch has been sitting in the ext4 patch queue for about
> > > six weeks. It was there it was a suspected cause for block allocation
> > > bug. As I recall, it we found the true root cause since then, but this
> > > has stuck around since it's a potential problem. Andrew has expressed
> > > concerns that this patch might have performance impacts.
> >
> > Performace impacts I guess we'll just have to put up with. iirc I was
> > thinking that this implementation should be pushed down to a kernel-wide
> > atomic64_t and then the percpu_counters would just use that type.
>
> something like so?

We should think about and document the contexts in which these things
can be used. Possibly add runtime checks too. afaict they shouldn't be used in
hard IRQs, and that's pretty unusual for an atomic type.




\
 
 \ /
  Last update: 2008-10-07 20:07    [W:0.073 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site