lkml.org 
[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32 bit architecture
From
Date
On Tue, 2008-10-07 at 18:09 +0100, richard kennedy wrote:
> Peter Zijlstra wrote:
> .....
> > +static inline int atomic64_dec_and_test(atomic64_t *v)
> > +{
> > + int ret;
> > +
> > + write_seqlock(&v->slock);
> > + v->counter--;
> > + ret = !v->counter;
> > + write_sequnlock(&v->slock);
> > +
> > + return ret;
> > +}
> > +
> > +static inline int atomic64_add_and_test(atomic64_t *v)
> > +{
> > + int ret;
> > +
> > + write_seqlock(&v->slock);
> > + v->counter++;
> > + ret = !v->counter;
> > + write_sequnlock(&v->slock);
> > +
> > + return ret;
> > +}
> would it be more logical to call this atomic64_inc_and_test to match the
> above dec_and_test ?

Yeah, I know of at least 2 other bugs in here, but I wanted some real
early feedback :-)



\
 
 \ /
  Last update: 2008-10-07 19:25    [W:0.027 / U:33.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site