[lkml]   [2008]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] markers: fix missing modpost entry in Module.markers

    commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
    marker points compiled in vmlinux are missing in Module.markers.

    # cat Module.markers
    subsystem_event samples/markers/marker-example integer %d string %s
    subsystem_eventb samples/markers/marker-example

    # stap -e 'probe kernel.mark("core_marker_format"){} '
    semantic error: no match while resolving probe point kernel.mark("core_marker_format")
    semantic error: no probes found
    Pass 2: analysis failed. Try again with more '-v' (verbose) options.

    This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
    Other parts have fixed duplicate modpost entry bug.

    Signed-off-by: Lai Jiangshan <>
    diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
    index 418cd7d..3509142 100644
    --- a/scripts/mod/modpost.c
    +++ b/scripts/mod/modpost.c
    @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
    mod->skip = 1;

    - if (!mod->skip)
    - add_marker(mod, marker, fmt);
    + add_marker(mod, marker, fmt);

     \ /
      Last update: 2008-10-07 08:41    [W:0.021 / U:16.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site