lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 36/76] tty: Make get_current_tty use a kref
On Mon, Oct 06, 2008 at 12:35:40PM +0200, Louis Rilling wrote:
> > tty = get_current_tty();
> > if (!tty || tty->driver->major != IBM_TTY3270_MAJOR) {
> > - mutex_unlock(&tty_mutex);
> > + tty_kref_put(tty);
>
> Should'nt mutex_unlock() be kept?

Yes.. although it gets fixed later but I will fix that as it will keep the
code bisectable.


\
 
 \ /
  Last update: 2008-10-06 12:59    [W:0.073 / U:17.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site