Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH/RFC 0/4] Add stop_machine_get/put_threads to stop_machine infrastructrue. | Date | Mon, 6 Oct 2008 14:42:40 +1000 |
| |
On Friday 03 October 2008 20:56:32 you wrote: > However we need to be able to do that without allocating any memory.
Nice work Heiko!
See free_module(), which calls stop_machine and, well, just hopes it works. So we've needed this for a while.
> Patch 1 is a stop_machine bugfix and is independent of the rest
Hmm, do you actually need this? It was a whim (and clearly a dumb one). I'm tempted to change it to:
err = smdata->fn(smdata->data); if (err) smdata->fnret = err;
> Patch 2 introduces the new proposed interface
Could we just encapsulate the threads etc. into a "struct stopmachine" which is returned from stop_machine_prepare(), then implement everything in terms of that?
Thanks, Rusty.
| |