lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 68/71] fbcon: fix monochrome color value calculation
    2.6.26-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: David Winn <q-newsgroup@qypea.com>

    commit 08650869e0ec581f8d88cfdb563d37f5383abfe2 upstream

    Commit 22af89aa0c0b4012a7431114a340efd3665a7617 ("fbcon: replace mono_col
    macro with static inline") changed the order of operations for computing
    monochrome color values. This generates 0xffff000f instead of 0x0000000f
    for a 4 bit monochrome color, leading to image corruption if it is passed
    to cfb_imageblit or other similar functions. Fix it up.

    Cc: Harvey Harrison <harvey.harrison@gmail.com>
    Cc: "Antonino A. Daplas" <adaplas@pol.net>
    Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/video/console/fbcon.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/video/console/fbcon.h
    +++ b/drivers/video/console/fbcon.h
    @@ -110,7 +110,7 @@ static inline int mono_col(const struct
    __u32 max_len;
    max_len = max(info->var.green.length, info->var.red.length);
    max_len = max(info->var.blue.length, max_len);
    - return ~(0xfff << (max_len & 0xff));
    + return (~(0xfff << max_len)) & 0xff;
    }

    static inline int attr_col_ec(int shift, struct vc_data *vc,
    --


    \
     
     \ /
      Last update: 2008-10-07 03:07    [W:4.183 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site