lkml.org 
[lkml]   [2008]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] pata_of_platform: fix no irq handling
    When no irq specified the pata_of_platform fills the irq_res with -1,
    which is wrong to do for two reasons:

    1. By definition, 'no irq' should be IRQ 0, not some negative integer;
    2. pata_platform checks for irq_res.start > 0, but since irq_res.start
    is unsigned type, the check will be true for `-1'.

    Reported-by: Steven A. Falco <sfalco@harris.com>
    Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
    ---

    Resending again...

    drivers/ata/pata_of_platform.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
    index 408da30..1f18ad9 100644
    --- a/drivers/ata/pata_of_platform.c
    +++ b/drivers/ata/pata_of_platform.c
    @@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct of_device *ofdev,

    ret = of_irq_to_resource(dn, 0, &irq_res);
    if (ret == NO_IRQ)
    - irq_res.start = irq_res.end = -1;
    + irq_res.start = irq_res.end = 0;
    else
    irq_res.flags = 0;

    --
    1.5.6.3


    \
     
     \ /
      Last update: 2008-10-06 19:29    [W:0.025 / U:212.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site