Messages in this thread | | | Date | Fri, 31 Oct 2008 11:32:42 -0400 | From | "Abhishek Sagar" <> | Subject | Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs |
| |
On Fri, Oct 31, 2008 at 10:36 AM, Steven Rostedt <rostedt@goodmis.org> wrote: >> Hi Abhishek, >> >> Now that this code is in mainline, it has become apparent that >> kretprobe_trampoline is not defined on all archs as a global like it is in >> x86. This needs to be fixed (it breaks ia64 build). >> > > Also note that kretprobe_trampoline will not be the return address. > > Hmm, I think I can solve this by not even doing the test here, but simply > on the name itself.
Ok. I wonder if it would be a good idea to export kretprobe_trampoline (or kretprobe_trampoline->ip) via asm/kprobes.h for all archs, for the kind of checks done here for ftrace (to have them elsewhere too like in OOPs generation etc).
Adding Kprobe folks in CC
-- Abhishek
| |