lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: fix missing cpu_index initialisation
On Thu, Oct 30, 2008 at 2:13 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> >From f49bbb826d8ec87609a63fb014af6aacb16aac38 Mon Sep 17 00:00:00 2001
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
> Date: Wed, 29 Oct 2008 15:13:09 -0500
> Subject: [VOYAGER] x86: fix missing cpu_index initialisation
>
> Ever since
>
> commit 92cb7612aee39642d109b8d935ad265e602c0563
> Author: Mike Travis <travis@sgi.com>
> Date: Fri Oct 19 20:35:04 2007 +0200
>
> x86: convert cpuinfo_x86 array to a per_cpu array
>
> We've had an extra field in cpuinfo_x86 which is cpu_index.
> Unfortunately, voyager has never initialised this, although the only
> noticeable impact seems to be that /proc/cpuinfo shows all zeros for
> the processor ids.
>
> Anyway, fix this by initialising the boot CPU properly and setting the
> index when the secondaries update.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> ---
>
> Depends on [VOYAGER] x86: add ability to test for boot CPU
>
> arch/x86/kernel/cpu/common.c | 2 ++
> arch/x86/mach-voyager/voyager_smp.c | 1 +
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 93e9393..da8f15a 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -549,6 +549,8 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
> this_cpu->c_early_init(c);
>
> validate_pat_support(c);
> +
> + c->cpu_index = boot_cpu_id;
> }
...
CC arch/x86/kernel/cpu/common.o
arch/x86/kernel/cpu/common.c: In function 'early_identify_cpu':
arch/x86/kernel/cpu/common.c:553: error: 'boot_cpu_id' undeclared
(first use in this function)
arch/x86/kernel/cpu/common.c:553: error: (Each undeclared identifier
is reported only once
arch/x86/kernel/cpu/common.c:553: error: for each function it appears in.)
make[2]: *** [arch/x86/kernel/cpu/common.o] Error 1
make[1]: *** [arch/x86/kernel/cpu] Error 2
make: *** [arch/x86/kernel] Error 2

YH


\
 
 \ /
  Last update: 2008-10-30 22:23    [W:0.066 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site