lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: hid: struct device - replace bus_id with dev_name(), dev_set_name()
    From
    Date
    On Thu, 2008-10-30 at 20:25 +0100, Jiri Slaby wrote:
    > Kay Sievers napsal(a):
    > > switch over to the new api, which will remove the 20 bytes array
    > > and does no longer have a size limitation.
    >
    > Cool!

    > Could you left the comment above to remind us about removing this ugly hack
    > later when the new non-limited api will be used?

    Sure!

    Thanks,
    Kay



    From: Kay Sievers <kay.sievers@vrfy.org>
    Subject: hid: struct device - replace bus_id with dev_name(), dev_set_name()

    CC: Jiri Kosina <jkosina@suse.cz>
    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-Off-By: Kay Sievers <kay.sievers@vrfy.org>
    ---

    diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
    index 1903e75..27f1e16 100644
    --- a/drivers/hid/hid-core.c
    +++ b/drivers/hid/hid-core.c
    @@ -1613,9 +1613,10 @@ int hid_add_device(struct hid_device *hdev)
    if (hid_ignore(hdev))
    return -ENODEV;

    - /* XXX hack, any other cleaner solution < 20 bus_id bytes? */
    - sprintf(hdev->dev.bus_id, "%04X:%04X:%04X.%04X", hdev->bus,
    - hdev->vendor, hdev->product, atomic_inc_return(&id));
    + /* XXX hack, any other cleaner solution after the driver core
    + * is converted to allow more than 20 bytes as the device name? */
    + dev_set_name(&hdev->dev, "%04X:%04X:%04X.%04X", hdev->bus,
    + hdev->vendor, hdev->product, atomic_inc_return(&id));

    ret = device_add(&hdev->dev);
    if (!ret)



    \
     
     \ /
      Last update: 2008-10-30 20:49    [W:0.048 / U:59.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site