lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/cpu.c: Section mismatch warning fix.

* Rakib Mullick <rakib.mullick@gmail.com> wrote:

> LD kernel/built-in.o
> WARNING: kernel/built-in.o(.text+0xb7c8): Section mismatch in
> reference from the function notify_cpu_starting() to the variable
> .cpuinit.data:cpu_chain
> The function notify_cpu_starting() references
> the variable __cpuinitdata cpu_chain.
> This is often because notify_cpu_starting lacks a __cpuinitdata
> annotation or the annotation of cpu_chain is wrong.
>
> This patch fixes the above section mismatch warning. If anything else
> please notice.
> Thanks.
>
> Signed-off-by: Md.Rakib H. Mullick <rakib.mullick@gmail.com>
>
> --- linux-2.6-orig/kernel/cpu.c 2008-10-28 20:52:38.000000000 +0600
> +++ linux-2.6/kernel/cpu.c 2008-10-28 22:46:22.000000000 +0600
> @@ -462,7 +462,7 @@ out:
> * It must be called by the arch code on the new cpu, before the new cpu
> * enables interrupts and before the "boot" cpu returns from __cpu_up().
> */
> -void notify_cpu_starting(unsigned int cpu)
> +void __cpuinit notify_cpu_starting(unsigned int cpu)
> {
> unsigned long val = CPU_STARTING;

you've tested that on x86, right? Have you checked/reviewed all the
non-x86 architecture codepaths:

./arch/m32r/kernel/smpboot.c: notify_cpu_starting(cpu_id);
./arch/cris/arch-v32/kernel/smp.c: notify_cpu_starting(cpu);
./arch/s390/kernel/smp.c: notify_cpu_starting(smp_processor_id());
./arch/x86/mach-voyager/voyager_smp.c: notify_cpu_starting(cpuid);
./arch/x86/kernel/smpboot.c: notify_cpu_starting(cpuid);
./arch/mips/kernel/smp.c: notify_cpu_starting(cpu);
./arch/sparc64/kernel/smp.c: notify_cpu_starting(cpuid);
./arch/ia64/kernel/smpboot.c: notify_cpu_starting(cpuid);
./arch/um/kernel/smp.c: notify_cpu_starting(cpu);
./arch/sparc/kernel/sun4d_smp.c: notify_cpu_starting(cpuid);
./arch/sparc/kernel/sun4m_smp.c: notify_cpu_starting(cpuid);
./arch/powerpc/kernel/smp.c: notify_cpu_starting(cpu);
./arch/alpha/kernel/smp.c: notify_cpu_starting(cpuid);
./arch/sh/kernel/smp.c: notify_cpu_starting(smp_processor_id());
./arch/arm/kernel/smp.c: notify_cpu_starting(cpu);

to make sure that they never use this function after free_initmem()?

Ingo


\
 
 \ /
  Last update: 2008-10-30 19:29    [W:0.123 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site