Messages in this thread | | | Date | Thu, 30 Oct 2008 12:40:28 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 01/10] sound/ice1712: indentation & braces disagree - add braces |
| |
At Thu, 30 Oct 2008 13:09:55 +0200 (EET), =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= wrote: > > Neither has any significance currently to the flow > because err is checked for the same condition before > the place of disagreement. > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Doh, that must come from the last coding-style fix patch. Applied now and will be in the next pull request.
Thanks!
Takashi
> --- > sound/pci/ice1712/ice1712.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c > index 5b44238..58d7cda 100644 > --- a/sound/pci/ice1712/ice1712.c > +++ b/sound/pci/ice1712/ice1712.c > @@ -2688,12 +2688,13 @@ static int __devinit snd_ice1712_probe(struct pci_dev *pci, > return err; > } > > - if (ice_has_con_ac97(ice)) > + if (ice_has_con_ac97(ice)) { > err = snd_ice1712_pcm(ice, pcm_dev++, NULL); > if (err < 0) { > snd_card_free(card); > return err; > } > + } > > err = snd_ice1712_ac97_mixer(ice); > if (err < 0) { > @@ -2715,12 +2716,13 @@ static int __devinit snd_ice1712_probe(struct pci_dev *pci, > } > } > > - if (ice_has_con_ac97(ice)) > + if (ice_has_con_ac97(ice)) { > err = snd_ice1712_pcm_ds(ice, pcm_dev++, NULL); > if (err < 0) { > snd_card_free(card); > return err; > } > + } > > if (!c->no_mpu401) { > err = snd_mpu401_uart_new(card, 0, MPU401_HW_ICE1712, > -- > 1.5.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |