lkml.org 
[lkml]   [2008]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: mmc: struct device - replace bus_id with dev_name(), dev_set_name()
    From
    Date
    On Thu, 2008-10-30 at 05:37 +0100, Marcel Holtmann wrote:
    > Hi Harvey,
    > >
    > > A lot of these helpers don't seem to add that much, would you care for
    > > a patch removing them Pierre?
    > >
    > > Specifically sdio_func_id, sdio_get/set_drvdata don't have that many
    > > users.
    >
    > I prefer if we keep them. Since they take the proper parameter.
    > Otherwise the driver has to always got func->dev for everything. Most
    > SDIO drivers care of the function and not about the struct device
    > underneath it.
    >

    Sure, it just seemed odd to have a wrapper around a wrapper.

    Cheers,

    Harvey



    \
     
     \ /
      Last update: 2008-10-30 06:19    [W:0.021 / U:31.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site