Messages in this thread | | | Date | Fri, 03 Oct 2008 00:44:22 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M |
| |
Ingo Molnar wrote: >>> >>>> +++ arch/x86/kernel/cpu/mtrr/if.c 2008-10-03 00:22:34.000000000 +0200 >>>> @@ -16,7 +16,7 @@ >>>> static const char *const mtrr_strings[MTRR_NUM_TYPES] = >>>> { >>>> "uncachable", /* 0 */ >>>> - "write-combining", /* 1 */ >>>> + "write-combine", /* 1 */ >>> hm, maybe this bit could confuse versions of Xorg that modifies >>> /proc/mtrr - i.e. this could be part of the ABI towards user-space. >>> We'll see. >>> >> This *IS* part of the ABI toward userspace, although I think Xorg uses >> the ioctl() interface. > > yeah, but aspects of the ABI that applications do not rely on can > generally be changed. OTOH, i've undone this aspect of the patch - > /proc/mtrr is a legacy interface and changes to it are unnecessary. I > kept the boot printout cleanups. >
Great. It's worth noting that these strings aren't just used for readout, but also for setting.
-hpa
| |