Messages in this thread | | | Date | Fri, 3 Oct 2008 12:26:31 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH] x86 Topology cpu_to_node parameter check |
| |
On Fri, 3 Oct 2008, Mathieu Desnoyers wrote: > > That's how I did it first, but then I looked at asm-generic/topology.h > and have seen it uses #defines. Should we change them too ? >
The old way of doing this is with defines. But all new code should be static inline functions when feasible. This way we can get typechecking on the parameters even when the configuration is disabled.
Even if the rest of the file uses defines, the new code should be static inlines. Eventually, even the old defines will be converted.
-- Steve
| |