Messages in this thread Patch in this message | | | Date | Wed, 29 Oct 2008 17:06:47 -0400 | From | roel kluin <> | Subject | [PATCH] intel_menlo: max_state is unsigned, invalid test |
| |
max_state is unsigned, so the test is invalid.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- I think max_state can only become -1, no? then probably a different patch is required. I may not be able to respond for a few weeks.
diff --git a/drivers/misc/intel_menlow.c b/drivers/misc/intel_menlow.c index e00a275..980171d 100644 --- a/drivers/misc/intel_menlow.c +++ b/drivers/misc/intel_menlow.c @@ -121,7 +121,7 @@ static int memory_set_cur_bandwidth(struct thermal_cooling_device *cdev, if (memory_get_int_max_bandwidth(cdev, &max_state)) return -EFAULT; - if (max_state < 0 || state > max_state) + if (max_state == -1 || state > max_state) return -EINVAL; arg_list.count = 1;
| |