lkml.org 
[lkml]   [2008]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()
On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
>> From: Pekka Enberg <penberg@cs.helsinki.fi>
>>
>> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
>> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
>> MLMESendFrame() returns.

On Tue, Oct 28, 2008 at 9:32 PM, Pavel Machek <pavel@suse.cz> wrote:
> Acked-by: Pavel Machek <pavel@suse.cz>
>
> ...but I guess I should test the this after it hits the mainline...

For sure. I'm bit surprised no one noticed this before as it seems to
be leaking memory for every transmitted frame...


\
 
 \ /
  Last update: 2008-10-28 22:11    [W:0.213 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site