[lkml]   [2008]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] ftrace: fix current_tracer error return

    On Tue, 28 Oct 2008, Fr?d?ric Weisbecker wrote:

    > 2008/10/28 Steven Rostedt <>:
    > >
    > > On Tue, 28 Oct 2008, Fr?d?ric Weisbecker wrote:
    > >>
    > >> An that corrects the bug when I failed to assign the sched_switch tracer.
    > >> Thanks Steven!
    > >>
    > >> Tested-by: Frederic Weisbecker <>
    > >
    > > Do you still have issues with the function tracer in the latest linux-tip?
    > > If so, can you rebuild it from scratch, send me the config again, and
    > > explain in detail what the issue is.
    > >
    > > Thanks,
    > I think I've caught it. See the patch I just Cc'ed you:
    > ftrace: perform an initialization for ftrace to enable it

    Ah! I see the issue.

    My test scripts automatically set or unset /proc/sys/kernel/ftrace_enabled

    I believe I wanted that to be default off when dynamic ftrace was not
    active. Currently, it really shouldn't matter, because there's a check to
    make sure that ftrace has a registered function before calling it.

    That was just my preference. But if you find it less confusing, then
    having ftrace_enabled as default on even when dynamic ftrace is not
    enabled, is fine with me.

    -- Steve

     \ /
      Last update: 2008-10-28 19:35    [W:0.019 / U:69.176 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site