lkml.org 
[lkml]   [2008]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lockdep: fix irqs on/off ip tracing

* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> 81d68a96 "ftrace: trace irq disabled critical timings" added wrappers around
> trace_hardirqs_on/off_caller. However these functions use
> __builtin_return_address(0) to figure out which function actually disabled
> or enabled irqs. The result is that we save the ips of trace_hardirqs_on/off
> instead of the real caller. Not very helpful.
> However since the patch from Steven the ip already gets passed. So use that
> and get rid of __builtin_return_address(0) in these two functions.
>
> Cc: Steven Rostedt <srostedt@redhat.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> kernel/lockdep.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)

good catch and nice cleanup, i've applied it to tip/core/urgent,
thanks Heiko!

Ingo


\
 
 \ /
  Last update: 2008-10-28 11:23    [W:0.286 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site