Messages in this thread | | | Date | Mon, 27 Oct 2008 23:34:03 -0400 | From | "Mike Frysinger" <> | Subject | Re: [PATCH] linux/video_{de,en}coder.h: cleanup for userspace |
| |
On Mon, Oct 27, 2008 at 11:31 PM, Andrew Morton wrote: > On Sun, 26 Oct 2008 06:47:44 -0400 Mike Frysinger wrote: >> Make sure the linux/video_{de,en}coder.h header files include other header >> files that they use (for types and structures). > > checkpatch (amazing tool, and it's free!) said: > > ERROR: Don't use <linux/videodev.h>: see Documentation/feature-removal-schedule.txt > #23: FILE: include/linux/video_decoder.h:5: > +#include <linux/videodev.h> > > so I'll drop this one.
maybe, but video_decoder.h def uses things in linux/videodev.h today. if we add the include, hopefully it'll help people realize they need to remove the relevant things from video_decoder.h as well. -mike
| |