Messages in this thread | | | Date | Mon, 27 Oct 2008 20:09:00 +0000 | From | Mark Brown <> | Subject | Re: [rtc-linux] [PATCH 2/2] rtc: rtc-wm8350: Add support for WM8350 RTC |
| |
On Mon, Oct 27, 2008 at 01:03:21PM -0700, David Brownell wrote: > On Monday 27 October 2008, Alessandro Zummo wrote: > > (and a detailed checklist at http://groups.google.com/group/rtc-linux/web/checklist )
> Also: rtc_ops.ioctl() method should only handle RTC_{AIE,UIE}_{ON,OFF}, > since the other standard ioctls have rtc_ops equivalents.
> (This code is fine in both respects. Though since I've received three > copies of the driver since it was merged to MM, maybe I missed something.)
Unfortunately I added the __devexit_p() annotation in response to Alessandro's comments. I'll remove it again, other than that all that's changed is a tweak to the module description and Andrew's change to use schedule_timeout_uninterruptible().
How should these drivers be merged? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |