Messages in this thread Patch in this message | | | Date | Mon, 27 Oct 2008 11:46:50 -0700 | From | Mike Travis <> | Subject | [PATCH 1/1] SGI x86 UV: Use raw_smp_processor_id |
| |
Subject: SGI x86 UV: Use raw_smp_processor_id
> one small comment: > >> + /* is this cpu idle? */ >> + if (idle_cpu(smp_processor_id())) >> bits &= ~SCIR_CPU_ACTIVITY; > > were you ever to run an -rt kernel on that hardware, this would > produce a warning. raw_smp_processor_id() would be more appropriate i > guess.
Thanks for the heads up! Yes, -rt is supported. Might as well avoid that problem now.
Signed-of-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/genx2apic_uv_x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- test-tip-latest.orig/arch/x86/kernel/genx2apic_uv_x.c +++ test-tip-latest/arch/x86/kernel/genx2apic_uv_x.c @@ -372,7 +372,7 @@ static void uv_heartbeat(unsigned long i bits ^= SCIR_CPU_HEARTBEAT; /* is this cpu idle? */ - if (idle_cpu(smp_processor_id())) + if (idle_cpu(raw_smp_processor_id())) bits &= ~SCIR_CPU_ACTIVITY; else bits |= SCIR_CPU_ACTIVITY;
| |