Messages in this thread | | | Date | Sat, 25 Oct 2008 14:25:42 +0200 | From | Markus Trippelsdorf <> | Subject | Re: [PATCH] Re: ext3: fix ext3_dx_readdir hash collision handling - Regression |
| |
On Sat, Oct 25, 2008 at 07:56:31AM -0400, Theodore Tso wrote: > > Unfortunately, the commit which which fixes the duplicated entries > when there are hash collisions wasn't properly setting info->curr_hash > and info->curr_minor_hash after going to the next node, which results > the first entry being returned twice on the subsequent getdents() > system call. What I don't understand was why I wasn't seeing this on > a 32-bit kernel (maybe I screwed up my test environment; this problem > should have occurred regardless of the 32-bit or 64-bit environment). > > In any case, if folks could test to see whether this patch fixes > things, I'd appreciate it. (Patch for ext3 and ext4 follows). > > - Ted
Yep, your patch fixes the issue. Thank you Ted.
-- Markus
| |