lkml.org 
[lkml]   [2008]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] libata: switch to using block layer tagging support
    On Wed, Oct 22, 2008 at 09:40:43AM +0200, Jens Axboe wrote:
    > libata currently has a pretty dumb ATA_MAX_QUEUE loop for finding
    > a free tag to use. Instead of fixing that up, convert libata to
    > using block layer tagging - gets rid of code in libata, and is also
    > much faster.
    >
    > Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

    Unfortunately this change breaks SATA for me, bisecting picked out this
    commit especially.

    Before:

    sata_sil 0000:00:01.0: Applying R_ERR on DMA activate FIS errata fix
    scsi0 : sata_sil
    scsi1 : sata_sil
    ata1: SATA max UDMA/100 mmio m512@0xfd000200 tf 0xfd000280 irq 66
    ata2: SATA max UDMA/100 mmio m512@0xfd000200 tf 0xfd0002c0 irq 66
    ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 310)
    ata1.00: ATA-7: SAMSUNG HM080JI, YC100-02, max UDMA7
    ata1.00: 156368016 sectors, multi 0: LBA48 NCQ (depth 0/32)
    ata1.00: configured for UDMA/100
    ata2: SATA link down (SStatus 0 SControl 310)
    scsi 0:0:0:0: Direct-Access ATA SAMSUNG HM080JI YC10 PQ: 0 ANSI: 5
    sd 0:0:0:0: [sda] 156368016 512-byte hardware sectors: (80.0 GB/74.5 GiB)
    sd 0:0:0:0: [sda] Write Protect is off
    sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
    sd 0:0:0:0: [sda] 156368016 512-byte hardware sectors: (80.0 GB/74.5 GiB)
    sd 0:0:0:0: [sda] Write Protect is off
    sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
    sda: sda1 sda2
    sd 0:0:0:0: [sda] Attached SCSI disk

    After:

    sata_sil 0000:00:01.0: Applying R_ERR on DMA activate FIS errata fix
    scsi0 : sata_sil
    scsi1 : sata_sil
    ata1: SATA max UDMA/100 mmio m512@0xfd000200 tf 0xfd000280 irq 66
    ata2: SATA max UDMA/100 mmio m512@0xfd000200 tf 0xfd0002c0 irq 66
    ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 310)
    ata1.00: ATA-7: SAMSUNG HM080JI, YC100-02, max UDMA7
    ata1.00: 156368016 sectors, multi 0: LBA48 NCQ (depth 0/32)
    ata1.00: configured for UDMA/100
    ata2: SATA link down (SStatus 0 SControl 310)
    scsi 0:0:0:0: Direct-Access ATA SAMSUNG HM080JI YC10 PQ: 0 ANSI: 5
    sd 0:0:0:0: [sda] 156368016 512-byte hardware sectors: (80.0 GB/74.5 GiB)
    sd 0:0:0:0: [sda] Write Protect is off
    sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
    sd 0:0:0:0: [sda] 156368016 512-byte hardware sectors: (80.0 GB/74.5 GiB)
    sd 0:0:0:0: [sda] Write Protect is off
    sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
    sda:

    Where it hangs until it times out after 180 seconds.

    Built with:

    CONFIG_ATA=y
    CONFIG_SATA_PMP=y
    CONFIG_ATA_SFF=y
    CONFIG_SATA_SIL=y

    I have no idea where to start looking at this, so hopefully someone has some
    suggestions :-)


    \
     
     \ /
      Last update: 2008-10-24 09:11    [W:0.023 / U:98.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site